Skip to content

Comments

refactor: update to py39 typehints and removeprefix#1396

Merged
onerandomusername merged 26 commits intomasterfrom
refactor/update-to-py39-typehints
Oct 19, 2025
Merged

refactor: update to py39 typehints and removeprefix#1396
onerandomusername merged 26 commits intomasterfrom
refactor/update-to-py39-typehints

Conversation

@onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Sep 21, 2025 •
edited
Loading

Updates all of the typehints in the project to 3.9 style typehinting. Also fixes a few methods to use removeprefix and removesuffix.

@onerandomusername onerandomusername requested a review from a team as a code owner September 21, 2025 20:34
@onerandomusername onerandomusername changed the base branch from master to feat/drop-py38 September 21, 2025 20:35
@onerandomusername onerandomusername added this to the disnake v2.12 milestone Sep 21, 2025
@github-project-automation github-project-automation bot moved this to Todo in disnake Sep 21, 2025
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 21, 2025 •
edited
Loading

Documentation build overview

📚 disnake | 🛠️ Build #29998765 | 📁 Comparing 53048bb against latest (f7374b7)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@onerandomusername onerandomusername force-pushed the refactor/update-to-py39-typehints branch from 7ac57e7 to e1a0bab Compare September 21, 2025 20:41
@onerandomusername onerandomusername changed the title refactor/update to py39 typehints refactor: update to py39 typehints and removeprefix Sep 21, 2025
@onerandomusername onerandomusername added s: blocked Issue/PR is blocked by other issues t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Sep 21, 2025
@onerandomusername onerandomusername marked this pull request as draft September 21, 2025 20:42
@onerandomusername onerandomusername mentioned this pull request Sep 23, 2025
Merged
8 tasks
Base automatically changed from feat/drop-py38 to master September 25, 2025 17:36
@onerandomusername onerandomusername marked this pull request as ready for review September 26, 2025 02:08
@onerandomusername onerandomusername added s: needs review Issue/PR is awaiting reviews and removed s: blocked Issue/PR is blocked by other issues labels Sep 26, 2025
@onerandomusername onerandomusername moved this from Todo to Needs Review in disnake Sep 26, 2025
shiftinv
shiftinv reviewed Oct 13, 2025
View reviewed changes
@shiftinv shiftinv force-pushed the refactor/update-to-py39-typehints branch 2 times, most recently from 3e1a156 to 18c8900 Compare October 13, 2025 18:43
onerandomusername and others added 3 commits October 13, 2025 14:50
@onerandomusername @shiftinv
Update changelog/1396.misc.rst
917a38f 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arielle <me@arielle.codes>
@onerandomusername @shiftinv
Update disnake/message.py
fa2de56 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arielle <me@arielle.codes>
@onerandomusername
fix: don't double assign self.endpoint
d23e519
Enegg
Enegg suggested changes Oct 13, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Needs Review to In Progress in disnake Oct 13, 2025
@shiftinv shiftinv mentioned this pull request Oct 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Needs Merge in disnake Oct 18, 2025
Enegg
Enegg reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@Enegg Enegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave up half way due to GitHub's suboptimal performance and made a PR: #1442

@onerandomusername onerandomusername enabled auto-merge (squash) October 19, 2025 19:00
@onerandomusername onerandomusername merged commit d171173 into master Oct 19, 2025
37 checks passed
@onerandomusername onerandomusername deleted the refactor/update-to-py39-typehints branch October 19, 2025 19:03
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in disnake Oct 19, 2025
@onerandomusername onerandomusername restored the refactor/update-to-py39-typehints branch October 19, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinv shiftinv shiftinv approved these changes

+1 more reviewer

@Enegg Enegg Enegg requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes

Projects

disnake
Status: Done

Milestone

disnake v2.12

Development

Successfully merging this pull request may close these issues.

3 participants

@onerandomusername @shiftinv @Enegg